refactor: Limit processing of blocks to requested fingerprint ranges in bloom gateway #11987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
commented
Feb 19, 2024
chaudum
changed the title
owen-d
approved these changes
Feb 19, 2024
pkg/bloomgateway/util_test.go
Outdated
| v1.NewBounds(0, 2), | ||
| v1.NewBounds(5, 19), | ||
| v1.NewBounds(25, 29), | ||
| }, |
There was a problem hiding this comment.
nit: add a test where there is no overlap but the comparison is between the other two:
mb := bounds(0,10) + bounds (30,40)
target = bounds(15,25)
pkg/bloomgateway/util.go
Outdated
|
|
||
| type MultiFingerprintBounds []v1.FingerprintBounds | ||
|
|
||
| func (mb MultiFingerprintBounds) Union(target v1.FingerprintBounds) MultiFingerprintBounds { |
There was a problem hiding this comment.
I think for this to behave as expected, the multi-bounds must be
a) sorted already
b) contain disjoint (non-overlapping) ranges
Otherwise you can end up with many overlapping ranges in the result set as well.
Consider:
multi = [(0,6), (5,15)]
target = (8,10)
result = [(0,6), (5,15)] // can be further reduced
Thinking about it, it's probably not a real concern we have if we can ensure the multi-bounds are ordered and non overlapping.
There was a problem hiding this comment.
I solved the issue by using a different algorithm.
salvacorts
approved these changes
Feb 20, 2024
This PR limits the amount of data being processed for a single multiplexed iteration to the union of the fingerprint bounds of its requests, instead of looking at blocks from the complete fingerprint range. Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/bloomgatway-limit-fp-range
branch
from
e29534d to
c8fc064
Compare
chaudum
changed the title
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
…in bloom gateway (grafana#11987) This PR limits the amount of data being processed for a single multiplexed iteration to the union of the fingerprint bounds of its requests, instead of looking at blocks from the complete fingerprint range. Signed-off-by: Christian Haudum <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…in bloom gateway (grafana#11987) This PR limits the amount of data being processed for a single multiplexed iteration to the union of the fingerprint bounds of its requests, instead of looking at blocks from the complete fingerprint range. Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR limits the amount of data being processed for a single multiplexed iteration to the union of the fingerprint bounds of its requests, instead of looking at blocks from the complete fingerprint range.