(chore) Bloom gateway: Improve fingerprint partitioning in client #11971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Benchmark results from `sort.Search` (old) vs. `slices.BinarySearchFunc` (new):
```
$ benchstat old.txt new.txt
goos: linux
goarch: amd64
pkg: github.com/grafana/loki/pkg/bloomgateway
cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
PartitionFingerprintsByAddresses-8 18.75µ ± 70% 16.94µ ± 2% -9.68% (p=0.000 n=10)
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
PartitionFingerprintsByAddresses-8 18.69Ki ± 0% 18.69Ki ± 0% ~ (p=1.000 n=10) ¹
¹ all samples are equal
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
PartitionFingerprintsByAddresses-8 8.000 ± 0% 8.000 ± 0% ~ (p=1.000 n=10) ¹
¹ all samples are equal
```
Signed-off-by: Christian Haudum <[email protected]>
chaudum
changed the title
salvacorts
approved these changes
Feb 16, 2024
chaudum
deleted the
chaudum/bloomgateway-client-partition-fingerprints
branch
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…afana#11971) Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR re-implements the fingerprint partitioning on the bloom gateway client using
slices.BinarySearchFunc.Benchmark results from
sort.Search(old) vs.slices.BinarySearchFunc(new):