Bloom compactor: Load blocks lazily in batches #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
reviewed
Feb 12, 2024
| func newBatchedBlockLoader(ctx context.Context, fetcher blocksFetcher, blocks []bloomshipper.BlockRef) (*batchedBlockLoader, error) { | ||
| return &batchedBlockLoader{ | ||
| ctx: ctx, | ||
| batchSize: 10, // make configurable? |
There was a problem hiding this comment.
I agree this should be configurable
| err.Add(itr.CloseBatch()) | ||
| default: | ||
| // close remaining loaded blocks | ||
| for itr.Next() && itr.Err() == nil { |
There was a problem hiding this comment.
Would we ever reach here? As far as I can see closeLoadedBlocks is only called from buildBlocks which will pass whatever loadWorkForGap returns.
There was a problem hiding this comment.
Since the function accepts an interface v1.CloseableInterator[*bloomshipper.CloseableBlockQuerier] and not a concrete type, it could be possible that a non-batched version of the iterator is passed.
salvacorts
approved these changes
Feb 13, 2024
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/lazyloading-bloomcompactor-work
branch
from
dafa7f0 to
35c21ac
Compare
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…rs (grafana#11924) While reviewing grafana#11919, I figured it'd be nice to make `batchedLoader` generic so we can reuse it's logic. This let me test it easier and remove a lot of now-unnecessary adapter code (interfaces, types)
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
To avoid loading possibly lots of blocks upfront, this PR introduces lazy loading of blocks in batches using an iterator that loads blocks on demand. Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To avoid loading possibly lots of blocks upfront, this PR introduces lazy loading of blocks in batches using an iterator that loads blocks on demand.
This is the first part of making the block loading truly lazy.
As a second part, the interface of the merge build is going to change so it accepts a single iterator.