Bloom/running #11918
Merged
Bloom/running #11918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
uses readonly store only when bloomcompactor is target, not a dependency Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
github-actions
bot
added
the
type/docs
chaudum
approved these changes
Feb 12, 2024
| @@ -648,7 +651,7 @@ func (t *Loki) setupModuleManager() error { | |||
| Write: {Ingester, Distributor}, | |||
| Backend: {QueryScheduler, Ruler, Compactor, IndexGateway, BloomGateway, BloomCompactor}, | |||
|
|
|||
| All: {QueryScheduler, QueryFrontend, Querier, Ingester, Distributor, Ruler, Compactor}, | |||
| All: {QueryScheduler, QueryFrontend, Querier, Ingester, Distributor, Ruler, Compactor, BloomCompactor}, | |||
There was a problem hiding this comment.
Up for discussion, but I don't think that we want to include the bloom compactor in the all target.
For testing, it comes handy, I understand.
There was a problem hiding this comment.
I don't think users of the monolith mode will benefit from building blooms significantly, right? In addition to that, it will increase resource usage and operational burden. - So I think we should remove it, or add a feature flag for that which defaults to false (e.g. enable_bloom_compactor_all_target).
There was a problem hiding this comment.
Fair points all around, but we can leave it to enable better testing then remove it prior to release.
salvacorts
approved these changes
Feb 12, 2024
chaudum
reviewed
Feb 12, 2024
pkg/bloomcompactor/spec.go
Outdated
| @@ -313,6 +311,12 @@ func (b *batchedLoader) Next() bool { | |||
| } | |||
|
|
|||
| b.batch, b.err = next.fetcher.FetchChunks(b.ctx, toFetch) | |||
| return b.prepNext() | |||
There was a problem hiding this comment.
FetchChunks may return an error, then len(b.batch) is 0, which will cause an out of bounds error in prepNext().
There was a problem hiding this comment.
Good catch, will fix. Thanks
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Includes a few small fixes in order to get the compactor running, including * Wires up i/o from `v1` pkg and the `bloomshipper` pkg in order to archive+write blocks remotely after building * config error handling * fix an error iterating chunks * handles gzipping when loading tsdbs from storage * bypasses internal cache in `BloomTSDBStore`'s internal `indexshipper/storage.Client` to get up to date results, which is easier for prototyping * `ClosableReadSeekerAdapter` --------- Signed-off-by: Christian Haudum <[email protected]> Signed-off-by: Owen Diehl <[email protected]> Co-authored-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a few small fixes in order to get the compactor running, including
v1pkg and thebloomshipperpkg in order to archive+write blocks remotely after buildingBloomTSDBStore's internalindexshipper/storage.Clientto get up to date results, which is easier for prototypingClosableReadSeekerAdapter