Fix test utility function MkBasicSeriesWithBlooms
#11909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keys returned by this function were all the same because the byteslice was not copied, but reused in the for loop. Also fixed the line that is tokenized to not yield duplicate tokens. Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/fix-mkbasicserieswithblooms
branch
from
ad54457 to
0006450
Compare
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
owen-d
approved these changes
Feb 9, 2024
salvacorts
approved these changes
Feb 9, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
The utility correctly populated the blooms, but returned incorrect values for `keys`, which are the indexed keys of a bloom. The values need to be copied when appending to the result slice. Additionally, the source for the tokenizer changed to be avoid duplicate keys that are present in all blooms. --------- Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The utility correctly populated the blooms, but returned incorrect values for
keys, which are the indexed keys of a bloom.The values need to be copied when appending to the result slice.
https://github.com/grafana/loki/pull/11909/files#diff-8aa1bba39beb779ea35f85fa9309b10d08637a2f6527f9fd4b26f59db79802e8L80
Additionally, the source for the tokenizer changed to be avoid duplicate keys that are present in all blooms.