[Blooms] Routing & wiring for bloom building #11894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
…as args Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
Signed-off-by: Owen Diehl <[email protected]>
owen-d
force-pushed
the
blooms/routing
branch
from
86e3214 to
51f28f3
Compare
chaudum
reviewed
Feb 8, 2024
| type DayTable model.Time | ||
|
|
||
| func (d DayTable) String() string { | ||
| return fmt.Sprintf("%d", d.ModelTime().Time().UnixNano()/int64(config.ObjectStorageIndexRequiredPeriod)) |
There was a problem hiding this comment.
At some point we need to add the prefix from the schema config.
There was a problem hiding this comment.
A string as table representation is quite confusing, because it may or may not contain the prefix.
pkg/bloomcompactor/router.go
Outdated
| return model.Time(d) | ||
| } | ||
|
|
||
| func (d DayTable) Bounds() (start, end model.Time) { |
There was a problem hiding this comment.
Could return bloomshipper.Interval.
Comment on lines
+89
to
+92
| buf, err := io.ReadAll(data) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to read file") | ||
| } |
There was a problem hiding this comment.
Do we want to load the full index into memory?
There was a problem hiding this comment.
I think this is easier (especially for now). Individual TSDBs can vary in size, but are commonly a couple hundred MB. We can optimize this if it becomes a problem, but it's easier to just load these into memory for now.
| return err | ||
| } | ||
|
|
||
| ticker := time.NewTicker(r.interval) |
There was a problem hiding this comment.
ticker should be stopped on exit
Signed-off-by: Owen Diehl <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
A few changes wiring up bloom building logic: * A `Router` as the controlling mechanism for iterating tenants+periods, queueing work for parallel computation, determining which fingerprint ranges and tenants are owned by a replica, and waiting for it's completion * Updates the `SimplerBloomController` to accept ownership ranges, periods, and tenants as arguments for use by the `Router` * Builds a `BloomTSDBStore` struct around the `indexshipper/storage.Client` interface in order to iterate relevant TSDBs/etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes wiring up bloom building logic:
Routeras the controlling mechanism for iterating tenants+periods, queueing work for parallel computation, determining which fingerprint ranges and tenants are owned by a replica, and waiting for it's completionSimplerBloomControllerto accept ownership ranges, periods, and tenants as arguments for use by theRouterBloomTSDBStorestruct around theindexshipper/storage.Clientinterface in order to iterate relevant TSDBs/etc