Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: Add support for running with Google Workload Identity #11869

Merged
merged 9 commits into from
Feb 8, 2024
Merged

operator: Add support for running with Google Workload Identity #11869

merged 9 commits into from
Feb 8, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Feb 5, 2024

What this PR does / why we need it:
This PR adds support for configuring LokiStack to make use of Google Workload Identity when communicating with the Google Storage.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Feb 5, 2024
@periklis periklis requested review from xperimental and a team as code owners February 5, 2024 20:07
JoaoBraveCoding
JoaoBraveCoding approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (did not manually test)

xperimental
xperimental reviewed Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a cluster, works fine 👍

A few nitpicks and one suggestion for an extra validation.

operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
xperimental
xperimental approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. I have added one suggestion for a (in my opinion) easier to understand error message, but I'm approving anyway.

operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets_test.go Outdated Show resolved Hide resolved
@periklis periklis enabled auto-merge (squash) February 8, 2024 18:21
@periklis periklis merged commit 5914df7 into grafana:main Feb 8, 2024
14 of 15 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@periklis @xperimental @rhnasc
operator: Add support for running with Google Workload Identity (graf…
75c69f1 
…ana#11869)

Co-authored-by: Robert Jacob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental xperimental approved these changes

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

Assignees

@periklis periklis

Labels
sig/operator size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@periklis @xperimental @JoaoBraveCoding