Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: fix install path for loki.service & promtail.service #11866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ulidtko
Copy link

@ulidtko ulidtko commented Feb 5, 2024

Small fix in Linux packaging.

There's a convention documented in man systemd.unit:

  • /etc/systemd/system System units created by the administrator
  • /usr/lib/systemd/system System units installed by the distribution package manager

Typically, if a package ships a systemd .service (especially in native apt/yum/dnf packages), the unit-file gets installed under /usr/lib/systemd/system/ — while the /etc location is reserved for downstream system vendor.

Grafana got this right:

$ dpkg -L grafana-enterprise | grep systemd/system/
/usr/lib/systemd/system/grafana-server.service

Notes for reviewer:

Doubtful if this is worth a mention in CHANGELOG or any further docs besides this PR.
Please suggest briefly in review if it is.

I also don't expect any breakage in upgrades, dpkg/rpm should handle this just fine.
(Although the separation of vendor/sysadmin VS packager responsibility can became a bitterly moot topic — especially when packages start reaching under /etc/systemd/system...)

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ulidtko ulidtko requested a review from a team as a code owner February 5, 2024 17:03
@ulidtko ulidtko force-pushed the fix/systemd-service-packaging branch from c210add to 5c0b9b0 Compare February 5, 2024 17:07
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@ulidtko
Copy link
Author

ulidtko commented Feb 5, 2024

Hey @imiric, please review-approve?

@ulidtko ulidtko force-pushed the fix/systemd-service-packaging branch from 5c0b9b0 to a6b4cb9 Compare March 14, 2024 09:16
@ulidtko ulidtko force-pushed the fix/systemd-service-packaging branch from a6b4cb9 to 2a11be9 Compare July 30, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants