(chore) Bloomshipper: Separate store and client #11865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <[email protected]>
For compatibility reasons the BloomStore historically also implemented the Client interface. However, this led to different implementations of the same methods in the Store and in the Client. This commit removes the Client implementation from the BloomStore. It also separates test cases for the client and the store. Signed-off-by: Christian Haudum <[email protected]>
and fix incorrect empty response Signed-off-by: Christian Haudum <[email protected]>
and fix incorrect empty response Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/separate-store-and-client
branch
from
2926281 to
08f36d8
Compare
Signed-off-by: Christian Haudum <[email protected]>
owen-d
approved these changes
Feb 5, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: This PR removes the `StoreAndClient` interface that was accepted by the `BloomShipper`. Since the `BloomStore` had to not only implement the `Store` interface, but also the `Client` interface, it caused re-implementation of the same methods in different ways. Now the shipper solely relies on the `Store` interface. See individual commit messages for more context. Tests have been rewritten from scratch and placed in their own respective test files for store and client. --------- Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the
StoreAndClientinterface that was accepted by theBloomShipper. Since theBloomStorehad to not only implement theStoreinterface, but also theClientinterface, it caused re-implementation of the same methods in different ways.Now the shipper solely relies on the
Storeinterface.See individual commit messages for more context.
Tests have been rewritten from scratch and placed in their own respective test files for store and client.