(chore) Bloom shipper: Extend Interval struct with utility functions
#11841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
changed the title
Interval struct to bloom library
owen-d
reviewed
Jan 31, 2024
I don't have strong opinions on where the struct resides. I'll move it back to the shipper then. |
chaudum
force-pushed
the
chaudum/move-interval-struct
branch
from
d2233ea to
c747829
Compare
Similar to the FingerprintBounds struct in the blooms/v1 package. Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/move-interval-struct
branch
from
c747829 to
7fcbab7
Compare
chaudum
changed the title
Interval struct to bloom libraryInterval struct with utility functions
Signed-off-by: Christian Haudum <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
grafana#11841) Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Even though it is mainly used by the bloom shipper and bloom gateway, it should reside next to the FingerprintBounds, which has similar characteristics and utility functions.Update:
I reverted moving the struct, but kept the utility functions.