Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom/controller wiring #11831

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Bloom/controller wiring #11831

merged 7 commits into from
Jan 31, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 31, 2024

Functionality & testware for building bloom block plans.

@owen-d owen-d requested a review from a team as a code owner January 31, 2024 01:43
Signed-off-by: Owen Diehl <[email protected]>
@owen-d owen-d force-pushed the bloom/controller-wiring branch from 437e70e to 6c989a6 Compare January 31, 2024 02:30
if b.Min != other.Min {
return b.Min < other.Min
}
return b.Max <= other.Max
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be b.Max < other.Max?

for itr.Next() {
into = append(into, itr.At())
}
return into
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to return a potential error?

Suggested change
return into
return into, itr.Err()

Signed-off-by: Owen Diehl <[email protected]>
@owen-d owen-d enabled auto-merge (squash) January 31, 2024 17:18
Signed-off-by: Owen Diehl <[email protected]>
@owen-d owen-d merged commit 509f6f6 into grafana:main Jan 31, 2024
7 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Functionality & testware for building bloom block plans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants