Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k183] Support sharding of binary operation for non shardable side. #11639

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[k183] Support sharding of binary operation for non shardable side. #11639

merged 1 commit into from
Jan 10, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 03156ed from #11635

What this PR does / why we need it:
Sharding of a binary operation with one unshardable side has been broken for quite some time.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jeschkies @grafana-delivery-bot
Support sharding of binary operation for non shardable side. (#11635)
4629bc9 
Binary expressions with one un-shardable side have been broken for quite some time. The error `unimplemented` however was shadowed by some other code. It surfaced only with a fix for an issue with `quantile_over_time` with was solved with #11629

---------

Signed-off-by: Christian Haudum <[email protected]>
Co-authored-by: Christian Haudum <[email protected]>
(cherry picked from commit 03156ed)
@grafanabot grafanabot requested a review from a team as a code owner January 10, 2024 17:31
@grafanabot grafanabot added backport size/L type/bug Somehing is not working as expected labels Jan 10, 2024
@grafanabot grafanabot requested a review from chaudum January 10, 2024 17:31
@github-actions GitHub Actions
Copy link
Contributor

Trivy scan found the following vulnerabilities:

  • HIGH, Target: docker.io/grafana/loki:k183-08853f0 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libcrypto3 v3.1.3-r0. Fixed in v3.1.4-r0
  • HIGH, Target: docker.io/grafana/loki:k183-08853f0 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libssl3 v3.1.3-r0. Fixed in v3.1.4-r0
    \nTo see more details on these vulnerabilities, and how/where to fix them, please run docker build -t grafana/loki:k183-08853f0 -f cmd/loki/Dockerfile .
    trivy i grafana/loki:k183-08853f0 on your branch. If these were not introduced by your PR, please considering fixing them in via a subsequent PR. Thanks!

@chaudum chaudum merged commit d7b014e into k183 Jan 10, 2024
13 checks passed
@chaudum chaudum deleted the backport-11635-to-k183 branch January 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum Awaiting requested review from chaudum

Assignees
No one assigned
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grafanabot @chaudum @jeschkies