Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert map pooling from #11484 #11583

Closed
wants to merge 2 commits into from
Closed

revert map pooling from #11484 #11583

wants to merge 2 commits into from

Conversation

cstyan
Copy link
Contributor

@cstyan cstyan commented Jan 4, 2024

Since we're seeing panics related to this and we can't reproduce it in a test, safer to just roll the change back for now.

Signed-off-by: Callum Styan <[email protected]>
@cstyan cstyan requested a review from a team as a code owner January 4, 2024 21:06
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pools.....

@grafanabot
Copy link
Collaborator

Hello @cstyan!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Trivy scan found the following vulnerabilities:

  • HIGH, Target: docker.io/grafana/loki:main-599eed7 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libcrypto3 v3.1.3-r0. Fixed in v3.1.4-r0
  • HIGH, Target: docker.io/grafana/loki:main-599eed7 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libssl3 v3.1.3-r0. Fixed in v3.1.4-r0
    \nTo see more details on these vulnerabilities, and how/where to fix them, please run docker build -t grafana/loki:main-599eed7 -f cmd/loki/Dockerfile .
    trivy i grafana/loki:main-599eed7 on your branch. If these were not introduced by your PR, please considering fixing them in via a subsequent PR. Thanks!

@cstyan
Copy link
Contributor Author

cstyan commented Jan 10, 2024

closing, we've reverted this change completely in k183 and fixed properly in k184

@cstyan cstyan closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k183 size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants