-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add OpenShift CloudCredentials support for AWS STS #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifests/storage/configure.go
Trivy scan found the following vulnerabilities:
|
JoaoBraveCoding
changed the title
operator: adds AWS sts support
operator: adds CCO support for Openshift AWS STS
Dec 20, 2023
periklis
reviewed
Dec 20, 2023
JoaoBraveCoding
force-pushed
the
log-4701
branch
from
December 22, 2023 18:09
0f59e81
to
0e6f537
Compare
JoaoBraveCoding
force-pushed
the
log-4701
branch
4 times, most recently
from
January 5, 2024 09:39
f26c0c6
to
62fec93
Compare
Co-authored-by: Joao Marcal <[email protected]>
JoaoBraveCoding
commented
Jan 23, 2024
Co-authored-by: Joao Marcal <[email protected]>
Co-authored-by: Joao Marcal <[email protected]>
JoaoBraveCoding
commented
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (can't approve my own PR 😅)
periklis
approved these changes
Jan 25, 2024
auto-merge was automatically disabled
January 26, 2024 16:50
Merge queue setting changed
Gordejj
pushed a commit
to Gordejj/loki
that referenced
this pull request
Jan 29, 2024
…#11524) Co-authored-by: Periklis Tsirakidis <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…#11524) Co-authored-by: Periklis Tsirakidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The following PR adds auxiliary automation to reconcile the cloud credentials secret for OpenShift clusters installations on AWS using STS as the default method for cloud credentials. In detail the installation of the Loki Operator requires from the cluster administrator to provide a AWS Role ARN that will be used by the operands (i.e. Loki) to request short-lived token from STS to access S3. The enablement is based on the following OpenShift proposals:
Effectively the underlying implementation utilizes the
CredentialsRequest
using the Loki Operator AWS Role ARN to request the credentials secret from the OpenShift cloud-credentials-operator. It minimizes user input on object storage access for LokiStack installation to a list of buckets and an AWS region.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Depends on:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR