Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of minio #11409

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update version of minio #11409

wants to merge 2 commits into from

Conversation

tinhtq
Copy link

@tinhtq tinhtq commented Dec 8, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@tinhtq tinhtq requested a review from a team as a code owner December 8, 2023 02:37
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Trivy scan found the following vulnerabilities:

  • HIGH, Target: docker.io/grafana/loki:main-24fa648 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libcrypto3 v3.1.3-r0. Fixed in v3.1.4-r0
  • HIGH, Target: docker.io/grafana/loki:main-24fa648 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libssl3 v3.1.3-r0. Fixed in v3.1.4-r0
    \nTo see more details on these vulnerabilities, and how/where to fix them, please run docker build -t grafana/loki:main-24fa648 -f cmd/loki/Dockerfile .
    trivy i grafana/loki:main-24fa648 on your branch. If these were not introduced by your PR, please considering fixing them in via a subsequent PR. Thanks!

@MichelHollands
Copy link
Contributor

@tinhtq Thanks for the contribution. Can you also do the things mentioned in the Checklist for Helm chart changes. It's copied here below.

  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@ChrisJBurns
Copy link

Thanks for the PR @tinhtq , we're really needing this also as the version of of Minio now have deprecated commands that the old Chart contains, the new one hopefully fixes it

@MichelHollands
Copy link
Contributor

@tinhtq Please follow the instructions for the helm chart in the checklist so the Helm chart version is updated and the changelog is updated. Once that is done I can merge it.

@JStickler
Copy link
Contributor

@tinhtq Any chance you could find time to update this PR so that we could get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants