-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Helm): Support for Zone Awareness and rollout-operator #11404
Conversation
…epare for other components
…eat/zone-aware-helm
Trivy scan found the following vulnerabilities:
|
…eat/zone-aware-helm
I have added migration guide to migrate from single zone --> zone-aware, i have not written anything about how it could be done with downtime, let me know if this is something that is wanted. |
Could you let me know if this PR contains to many changes/to large for it to have a chance of being merged? |
Hi @MichelHollands or @JStickler, Are you able to review this PR, or am i missing something before this is possible? |
@alex5517 Sorry for the late reply. Due to holidays we had a backlog. This PR is a bit too big to merge as is, as you alluded to. Is it possible to split this into multiple smaller PRs? There's too much of a risk of breaking other installs with large PRs. Thanks for the contribution though, this is really impressive work. |
I understand.
Do you believe this approach would be feasible? While the labeling PR might still appear substantial, it primarily results from identical changes applied across all resources. However, examining the YAML generated (old vs new) should facilitate easier validation. Are you comfortable with reviewing and merging three distinct pull requests? Alternatively, I could create a pull request that quickly(hackish) integrates it into the helper.tpl file. Let me know your thoughts. |
Have you had time to consider my previous comment? |
Have you had time to consider my previous comment? |
What this PR does / why we need it:
Adds support for zone awareness and use of rollout-operator
It also makes some changes to labeling and annotations so that it is done in a similar way to how the mimir-distributed helm chart does it. - A few other "alignments" have been done with the way mimir-distributed helm chart does it.
Which issue(s) this PR fixes:
Fixes #N/A
Special notes for your reviewer:
I will be adding docs for how to migrate from single zone to zone-aware replication, and i know it is a large PR but i have have tried to keep it familiar by implementing it the "same" way as it is done for mimir-distributed helm chart, i have also used the "guide" (https://grafana.com/docs/loki/latest/operations/zone-ingesters/) for the jsonnet deployment to make the migration possible in almost the same way.
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR