Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt text to images #11400

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Add alt text to images #11400

merged 2 commits into from
Dec 7, 2023

Conversation

JStickler
Copy link
Contributor

Adding alt text to images that were flagged in this week's 404 and build error report.

@JStickler JStickler requested a review from a team as a code owner December 6, 2023 16:37
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Trivy scan found the following vulnerabilities:

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler merged commit f6b5cde into main Dec 7, 2023
10 checks passed
@JStickler JStickler deleted the alt-text branch December 7, 2023 14:23
@grafanabot
Copy link
Collaborator

The backport to release-2.9.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11400-to-release-2.9.x origin/release-2.9.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x f6b5cde1ea3ad1061157962348b22e76a2fa9a96

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-11400-to-release-2.9.x
# Create the PR body template
PR_BODY=$(gh pr view 11400 --json body --template 'Backport f6b5cde1ea3ad1061157962348b22e76a2fa9a96 from #11400{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release-2.9.x] Add alt text to images" --body-file - --label "size/XS" --label "type/docs" --label "backport" --base release-2.9.x --milestone release-2.9.x --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-11400-to-release-2.9.x

# Create a pull request where the `base` branch is `release-2.9.x` and the `compare`/`head` branch is `backport-11400-to-release-2.9.x`.

# Remove the local backport branch
git switch main
git branch -D backport-11400-to-release-2.9.x

rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Adding alt text to images that were flagged in this week's 404 and build
error report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x backport-failed size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants