Fix getFromThrough() function for ShortRefs
#11386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trivy scan found the following vulnerabilities:
|
chaudum
force-pushed
the
chaudum/fix-getfromthrough-func
branch
from
b9fc557 to
bd9287d
Compare
Since chunks don't necessarily have the same duration, we cannot assume that the last item of a slice sorted by From time also has the greatest Through time. Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/fix-getfromthrough-func
branch
from
bd9287d to
80141bb
Compare
salvacorts
approved these changes
Dec 5, 2023
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: Since chunks don't necessarily have the same duration, we cannot assume that the last item of a slice sorted by `From` time also has the greatest `Through` time. Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since chunks don't necessarily have the same duration, we cannot assume that the last item of a slice sorted by
Fromtime also has the greatestThroughtime.