Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove re-implementation of BytesBuffer pool #11244

Closed
wants to merge 1 commit into from

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Nov 16, 2023

There is already an implementation for a bucketed pool in the Prometheus utilities, which is also used elsewhere in the code.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

There is already an implementation for a bucketed pool
in the Prometheus utilities, which is also used elsewhere in the code.

Signed-off-by: Christian Haudum <[email protected]>
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@chaudum chaudum closed this Nov 16, 2023
@chaudum chaudum deleted the chaudum/remove-bytesbuffer-pool branch November 16, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant