Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to disable specific alert rules Loki #11241

Merged
merged 36 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b77ec74
Helm: Allow per alert rule disabling on Loki
Daniel-Vaz Nov 16, 2023
dff672c
Merge branch 'main' into main
Daniel-Vaz Nov 16, 2023
cd4f6bf
Merge branch 'main' into main
Daniel-Vaz Nov 16, 2023
088e9f7
Merge branch 'main' into main
Daniel-Vaz Nov 17, 2023
e8a0293
update loki chart values docs about alerting rules changes
Daniel-Vaz Nov 20, 2023
966bdf4
Merge branch 'main' of https://github.com/Daniel-Vaz/loki
Daniel-Vaz Nov 20, 2023
90f014f
Merge branch 'main' into main
Daniel-Vaz Nov 20, 2023
9f94948
fixed values comment typo
Daniel-Vaz Nov 20, 2023
9ebc1ea
Merge branch 'main' of https://github.com/Daniel-Vaz/loki
Daniel-Vaz Nov 20, 2023
3843338
Merge branch 'main' into main
Daniel-Vaz Nov 20, 2023
1126bff
bumped version plus updated readme and changelog
Daniel-Vaz Nov 22, 2023
e93c2e3
Merge branch 'main' into main
Daniel-Vaz Nov 22, 2023
b322753
Merge branch 'main' into main
Daniel-Vaz Nov 22, 2023
0412215
Merge branch 'main' into main
Daniel-Vaz Nov 22, 2023
1b86482
Merge branch 'main' into main
Daniel-Vaz Nov 23, 2023
153f1d6
Merge branch 'main' into main
Daniel-Vaz Nov 23, 2023
0797c5e
Merge branch 'main' into main
Daniel-Vaz Nov 27, 2023
7317bd7
Update production/helm/loki/values.yaml
Daniel-Vaz Nov 28, 2023
d1fda9b
Merge branch 'main' into main
Daniel-Vaz Nov 28, 2023
f88b2ae
Merge branch 'main' into main
Daniel-Vaz Nov 28, 2023
cefa4ae
Merge branch 'main' into main
Daniel-Vaz Dec 6, 2023
c186092
Merge branch 'main' into main
Daniel-Vaz Dec 11, 2023
5535a4a
Merge branch 'main' into main
Daniel-Vaz Dec 12, 2023
be947fa
Merge branch 'main' into main
Daniel-Vaz Dec 18, 2023
86f5a66
Merge branch 'main' into main
Daniel-Vaz Jan 10, 2024
e3a2b7d
ran helm-docs
Daniel-Vaz Jan 10, 2024
d7e419e
ran helm-docs
Daniel-Vaz Jan 10, 2024
6ad1306
Merge branch 'main' into main
Daniel-Vaz Jan 10, 2024
df43ad6
update
Daniel-Vaz Jan 10, 2024
ba24793
fix conflicts and add missing reference snippet
Daniel-Vaz Jan 16, 2024
2622fc5
Merge branch 'main' into main
Daniel-Vaz Jan 16, 2024
28d254c
Merge branch 'main' into main
Daniel-Vaz Jan 17, 2024
f5253c1
rm line
Daniel-Vaz Jan 17, 2024
fa7022c
Merge branch 'main' of https://github.com/Daniel-Vaz/loki
Daniel-Vaz Jan 17, 2024
645456f
rm line
Daniel-Vaz Jan 17, 2024
efbd44d
new line end of file
Daniel-Vaz Jan 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions production/helm/loki/src/alerts.yaml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
groups:
- name: "loki_alerts"
rules:
{{- if not (.Values.monitoring.rules.disabled.LokiRequestErrors | default false) }}
- alert: "LokiRequestErrors"
annotations:
message: |
Expand All @@ -17,6 +18,8 @@ groups:
{{- if .Values.monitoring.rules.additionalRuleLabels }}
{{ toYaml .Values.monitoring.rules.additionalRuleLabels | indent 10 }}
{{- end }}
{{- end }}
{{- if not (.Values.monitoring.rules.disabled.LokiRequestPanics | default false) }}
- alert: "LokiRequestPanics"
annotations:
message: |
Expand All @@ -28,6 +31,8 @@ groups:
{{- if .Values.monitoring.rules.additionalRuleLabels }}
{{ toYaml .Values.monitoring.rules.additionalRuleLabels | indent 10 }}
{{- end }}
{{- end }}
{{- if not (.Values.monitoring.rules.disabled.LokiRequestLatency | default false) }}
- alert: "LokiRequestLatency"
annotations:
message: |
Expand All @@ -40,6 +45,8 @@ groups:
{{- if .Values.monitoring.rules.additionalRuleLabels }}
{{ toYaml .Values.monitoring.rules.additionalRuleLabels | indent 10 }}
{{- end }}
{{- end }}
{{- if not (.Values.monitoring.rules.disabled.LokiTooManyCompactorsRunning | default false) }}
- alert: "LokiTooManyCompactorsRunning"
annotations:
message: |
Expand All @@ -52,6 +59,8 @@ groups:
{{- if .Values.monitoring.rules.additionalRuleLabels }}
{{ toYaml .Values.monitoring.rules.additionalRuleLabels | indent 10 }}
{{- end }}
{{- end }}
{{- if not (.Values.monitoring.rules.disabled.LokiCanaryLatency | default false) }}
- name: "loki_canaries_alerts"
rules:
- alert: "LokiCanaryLatency"
Expand All @@ -66,3 +75,4 @@ groups:
{{- if .Values.monitoring.rules.additionalRuleLabels }}
{{ toYaml .Values.monitoring.rules.additionalRuleLabels | indent 10 }}
{{- end }}
{{- end }}
4 changes: 4 additions & 0 deletions production/helm/loki/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,10 @@ monitoring:
enabled: true
# -- Include alerting rules
alerting: true
# -- Specify which alerts should be disabled
disabled: {}
# LokiRequestErrors: true
# LokiRequestPanics: true
# -- Alternative namespace to create PrometheusRule resources in
namespace: null
# -- Additional annotations for the rules PrometheusRule resource
Expand Down