-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Introduces cache to TSDB postings (#9621)" #11157
Conversation
f386f95
to
d70acc1
Compare
2c5ef19
to
b111488
Compare
This reverts commit 1221658.
b111488
to
abaf558
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pkg/storage/stores/shipper/indexshipper/tsdb/single_file_index.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Owen Diehl <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11157-to-release-2.8.x origin/release-2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 30fbe383411c56e0d7a6be11e2333ab2513a89c0 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-11157-to-release-2.8.x
# Create the PR body template
PR_BODY=$(gh pr view 11157 --json body --template 'Backport 30fbe383411c56e0d7a6be11e2333ab2513a89c0 from #11157{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release-2.8.x] Revert \"Introduces cache to TSDB postings (#9621)\"" --body-file - --label "size/XXL" --label "type/docs" --label "type/bug" --label "backport" --base release-2.8.x --milestone release-2.8.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-11157-to-release-2.8.x
# Create a pull request where the `base` branch is `release-2.8.x` and the `compare`/`head` branch is `backport-11157-to-release-2.8.x`.
# Remove the local backport branch
git switch main
git branch -D backport-11157-to-release-2.8.x |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11157-to-release-2.9.x origin/release-2.9.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 30fbe383411c56e0d7a6be11e2333ab2513a89c0 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-11157-to-release-2.9.x
# Create the PR body template
PR_BODY=$(gh pr view 11157 --json body --template 'Backport 30fbe383411c56e0d7a6be11e2333ab2513a89c0 from #11157{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release-2.9.x] Revert \"Introduces cache to TSDB postings (#9621)\"" --body-file - --label "size/XXL" --label "type/docs" --label "type/bug" --label "backport" --base release-2.9.x --milestone release-2.9.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-11157-to-release-2.9.x
# Create a pull request where the `base` branch is `release-2.9.x` and the `compare`/`head` branch is `backport-11157-to-release-2.9.x`.
# Remove the local backport branch
git switch main
git branch -D backport-11157-to-release-2.9.x |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-11157-to-k174 origin/k174
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 30fbe383411c56e0d7a6be11e2333ab2513a89c0 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-11157-to-k174
# Create the PR body template
PR_BODY=$(gh pr view 11157 --json body --template 'Backport 30fbe383411c56e0d7a6be11e2333ab2513a89c0 from #11157{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[k174] Revert \"Introduces cache to TSDB postings (#9621)\"" --body-file - --label "size/XXL" --label "type/docs" --label "type/bug" --label "backport" --base k174 --milestone k174 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-11157-to-k174
# Create a pull request where the `base` branch is `k174` and the `compare`/`head` branch is `backport-11157-to-k174`.
# Remove the local backport branch
git switch main
git branch -D backport-11157-to-k174 |
**What this PR does / why we need it**: Backport #11157 into k174
) This reverts commit 1221658. **What this PR does / why we need it**: We decided to discontinue the postings cache a few releases ago for not finding any evidences that postings was the culprit for the bad igw performance. Plus, we noticed a major issue with it: it doesn't bubble down shards correctly, so every query end up processing every shard.
This reverts commit 1221658.
What this PR does / why we need it:
We decided to discontinue the postings cache a few releases ago for not finding any evidences that postings was the culprit for the bad igw performance. Plus, we noticed a major issue with it: it doesn't bubble down shards correctly, so every query end up processing every shard.
My approach here was:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR