modified the sentence in a more understandable way #11140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilal Khan <[email protected]>
JStickler
reviewed
Nov 6, 2023
| @@ -94,7 +94,7 @@ Refer to [CONTRIBUTING.md](CONTRIBUTING.md) | |||
|
|
|||
| Loki can be run in a single host, no-dependencies mode using the following commands. | |||
|
|
|||
| You need `go`, we recommend using the version found in [our build Dockerfile](https://github.com/grafana/loki/blob/main/loki-build-image/Dockerfile) | |||
| You need to install `go`, and make sure to use the `go` version found in [our build Dockerfile](https://github.com/grafana/loki/blob/main/loki-build-image/Dockerfile) otherwise it may give you an error. | |||
There was a problem hiding this comment.
Suggested change
| You need to install `go`, and make sure to use the `go` version found in [our build Dockerfile](https://github.com/grafana/loki/blob/main/loki-build-image/Dockerfile) otherwise it may give you an error. | |
| You need to install `go`. We recommend using the `go` version found in [our build Dockerfile](https://github.com/grafana/loki/blob/main/loki-build-image/Dockerfile) to avoid errors. |
There was a problem hiding this comment.
@JStickler Do you want me to edit this message with a new one that you recommended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In this PR, I wrote a sentence in a more understandable way because I also faced a problem of installing the Go version found in the Dockerfile that you have given but after many tries when I read the sentence correctly I understood that I needed to update the Go version.
That's why I decided to improve this sentence to make it understandable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR