Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style] Data source as two words. #11124

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[Style] Data source as two words. #11124

merged 1 commit into from
Nov 2, 2023

Conversation

JStickler
Copy link
Contributor

What this PR does / why we need it:
Updating "datasource" to be "data source" per recent decision by Style Council.

@JStickler JStickler added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 2, 2023
@JStickler JStickler requested a review from a team as a code owner November 2, 2023 17:07
cstyan
cstyan approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

I'd always assumed Grafana referred to them as datasource one word, but I just checked and they use data source.

@JStickler
Copy link
Contributor Author

JStickler commented Nov 2, 2023 •
edited
Loading

It's currently not very standardized. The docs team is trying to make things more consistent.

@JStickler JStickler merged commit 4d61d0a into main Nov 2, 2023
8 checks passed
@JStickler JStickler deleted the data_source branch November 2, 2023 17:42
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@JStickler @rhnasc
[Style] Data source as two words. (grafana#11124)
f638de4 
**What this PR does / why we need it**:
Updating "datasource" to be "data source" per recent decision by Style
Council.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstyan cstyan cstyan approved these changes

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JStickler @cstyan