Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check switches on syntax.Expr for exhaustiveness. #11112

Closed
wants to merge 1 commit into from

Conversation

jeschkies
Copy link
Contributor

What this PR does / why we need it:
In preparation to serlialize the LogQL AST as JSON we are declaring the syntax.Expr as a "sum type" and test all switch statements on it to be exhaustive.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jeschkies jeschkies requested a review from a team as a code owner November 1, 2023 17:52
@jeschkies jeschkies changed the title Check switches on syntax.Expr for exhaustivness. Check switches on syntax.Expr for exhaustiveness. Nov 1, 2023
@jeschkies jeschkies closed this Nov 1, 2023
@jeschkies jeschkies deleted the karsten/walk-ast branch November 1, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant