add vulnerability scanning github action #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trivy scan found the following vulernbilities:
|
|
Snyk scan found the following vulnerabilities:
|
|
Trivy scan found the following vulnerabilities:
|
kavirajk
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
LGTM. thanks @trevorwhitney. Just one non-blocking clarification.
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| command: test | ||
| args: --severity-threshold=high --json-file-output=snyk.json |
There was a problem hiding this comment.
Q: rationale behind high value here?
There was a problem hiding this comment.
thought was to reduce noise by only showing high and above. I need to add that to the trivy action as well. would you prefer we make it medium? remove completely?
trevorwhitney
force-pushed
the
vuln-scan-gh-actions
branch
from
fbab807 to
3edd776
Compare
This reverts commit 9f7ce1f.
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Adds a GitHub action that will run `snyk` and `trivy` scans against PRs and comment on the PR if a high or critical vulnerability is found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a GitHub action that will run
snykandtrivyscans against PRs and publish the results as a comment on the PR.Examples of what the comments will look like can be seen on this PR. It will only add a single comment for each scanner in the future, this one has multiples because of some of the iterations it went though.