-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typo fixed] in CHANGELOG.md #11075
[Typo fixed] in CHANGELOG.md #11075
Conversation
@khalid586 Tagging five different people to review a non-urgent typo is unnecessary. If you're doing Hacktoberfest, the goal is to make meaningful contributions to a project, not to make additional work for maintainers. Your branch is out of date. |
Yes, I saw that. I'm still trying to decide if I'm going to close this PR and create a "spam" label for it. |
why would it be a spam? |
If a PR is not necessary then it should be closed , it should not be unchecked. |
I have read the rules but I think you didn't read my question properly. I asked why would it be a spam? I just corrected a mistake and generally these kinds of mistakes are hard to correct because generally nobody has that much time to go through the files/ whole project to fix such trivial errors thus they go unchecked. I just wanted to get my PR reviewed. Merge it or close it. How can you say it a spam PR? Help me understand. @JStickler And this PR wasn't for hacktoberfest. I don't even know if this repo will be counted or not . |
@khalid586 Your GitHub profile says you're a Hacktoberfest participant. If this PR wasn't for Hacktoberfest, then why did you feel the need to tag five different people rather than waiting for a maintainer to review it when they had time? Fixing a typo in the code, or a configuration parameter, or in a code example, or in the published docs is helpful because those typos might confuse users or prevent them from being able to use the software successfully. As I said before, the spirit of Hactoberfest is to encourage people to make meaningful contributions to open source. In past years maintainers have been flooded with XS pull requests that did not provide a great deal of value to their projects, but took up a lot of their time. |
What this PR does / why we need it:
Fixes Typo
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory.