Skip to content

Commit

Permalink
Add first step for creating a single bloom from series (#11115)
Browse files Browse the repository at this point in the history
**What this PR does / why we need it**:
This is the first step to create a bloom from a series. The logic to get tenants and tables is a temporary hack and will be replaced by the ring logic in #11154

**Which issue(s) this PR fixes**:
Fixes #<issue number>

**Special notes for your reviewer**:
It does not handle appending multiple blooms into blocks. 
It does not handle creating and uploading of meta files. 

**Checklist**
- [ ] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)
- [ ] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](0d4416a)
  • Loading branch information
poyzannur authored Nov 8, 2023
1 parent 30fbe38 commit fa378ac
Show file tree
Hide file tree
Showing 8 changed files with 320 additions and 123 deletions.
2 changes: 0 additions & 2 deletions docs/sources/configure/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -2532,8 +2532,6 @@ ring:
[enabled: <boolean> | default = false]
[working_directory: <string> | default = ""]
[max_look_back_period: <duration>]
```

### limits_config
Expand Down
5 changes: 5 additions & 0 deletions pkg/bloomcompactor/TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
* Should we consider configuring falsePosRate of sbf at runtime?
* Use tarGz, untarGz before uploding blocks to storage
* Return checksum from `BuildFrom`
* Move meta creation to an outer layer, ensure one meta.json per compaction cycle.
* Introduce back `maxLookBackPeriod` as `RejectOldSamplesMaxAge` limit in distributors
Loading

0 comments on commit fa378ac

Please sign in to comment.