PR remarks and TODO to handle edge case

Signed-off-by: Kaviraj <[email protected]>
grafana · Feb 19, 2024 · ef9afeb · ef9afeb
1 parent 655844f
commit ef9afeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -27,8 +27,8 @@ cmd/querytee/querytee
 dlv
 rootfs/
 dist
-coverage.txt
-test_results.txt
+*coverage.txt
+*test_results.txt
 .DS_Store
 .aws-sam
 .idea

diff --git a/pkg/logql/rangemapper.go b/pkg/logql/rangemapper.go
@@ -377,7 +377,9 @@ func (m RangeMapper) rangeSplitAlign(
 	}
 
 	var (
-		newRng               = align
+		newRng = align
+
+		// TODO(kavi): If the originalOffset is non-zero, there may be a edge case, where subqueries generated won't be aligned correctly. Handle this edge case in separate PR.
 		newOffset            = originalOffset
 		downstreams          *ConcatSampleExpr
 		pendingRangeInterval = rangeInterval
@@ -389,7 +391,7 @@ func (m RangeMapper) rangeSplitAlign(
 	splits++
 
 	newOffset += align // e.g: offset 34m
-	pendingRangeInterval -= align
+	pendingRangeInterval -= newRng
 	newRng = m.splitByInterval // [1h]
 
 	// Rest of the subqueries.