small updates

Signed-off-by: Owen Diehl <[email protected]>
grafana · Oct 7, 2024 · ec56013 · ec56013
1 parent 8180573
commit ec56013
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/dash/dash.go b/pkg/dash/dash.go
@@ -76,8 +76,7 @@ func ReadsDashboard(requestDuration *prom.HistogramVec) (dashboard.Dashboard, er
 		"pod",
 	)
 
-	builder := dashboard.NewDashboardBuilder("Sample dashboard").
-		Uid("generated-from-go").
+	builder := dashboard.NewDashboardBuilder("Loki Reads (generated)").
 		Tags([]string{"generated", "from", "go"}).
 		Refresh("1m").
 		Time("now-30m", "now").

diff --git a/pkg/loki/modules.go b/pkg/loki/modules.go
@@ -1782,7 +1782,10 @@ func (t *Loki) initDashboards() (services.Service, error) {
 		return nil, err
 	}
 	t.Server.HTTP.Path("/grafana/dashboards/reads").Methods("GET").Handler(loader.Reads())
-	return services.NewBasicService(nil, nil, nil), nil
+	return services.NewBasicService(nil, func(serviceContext context.Context) error {
+		<-serviceContext.Done()
+		return nil
+	}, nil), nil
 }
 
 func (t *Loki) deleteRequestsClient(clientType string, limits limiter.CombinedLimits) (deletion.DeleteRequestsClient, error) {