Skip to content

Commit

Permalink
Bloom gateway: Fix bug in removal of filtered out chunks
Browse files Browse the repository at this point in the history
After chunks were successfully filtered, the bug was within the removal
of the chunks from the original list. It only filtered out the chunks
from the last partial response from the block querier.

Signed-off-by: Christian Haudum <[email protected]>
  • Loading branch information
chaudum committed Jan 15, 2024
1 parent 4f8b5fe commit e732ea3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/bloomgateway/bloomgateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func (g *Gateway) FilterChunkRefs(ctx context.Context, req *logproto.FilterChunk
// wait for all parts of the full response
if len(responses) == requestCount {
for _, o := range responses {
if res.Removals.Len() == 0 {
if o.Removals.Len() == 0 {
continue
}
// we must not remove items from req.Refs as long as the worker may iterater over them
Expand Down

0 comments on commit e732ea3

Please sign in to comment.