Skip to content

Commit

Permalink
chore(dependabot): Change event type to pull_request. (#10144)
Browse files Browse the repository at this point in the history
**What this PR does / why we need it**:
We are still facing permission error in enabling auto-merge for
dependabot PRs example:
https://github.com/grafana/loki/actions/runs/5737803871/job/15550129786?pr=10138

After discussing it with internal security team, they asked to try
changing the event type from `pull_request_target` -> `pull_request`.

Personally, I suspect this would make any difference, given It worked
with `pull_request_target` when testing it with my personal repo.

https://github.com/kavirajk/dependabot-play/blob/main/.github/workflows/dependabot_reviewer.yml#L5

Auto-merged PR.
kavirajk/dependabot-play#15

But still wanted to test this.
**Which issue(s) this PR fixes**:
Fixes #<issue number>

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)

Signed-off-by: Kaviraj <[email protected]>
  • Loading branch information
kavirajk authored Aug 2, 2023
1 parent 1b80a2f commit c795565
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/dependabot_reviewer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions

name: Auto-review Dependabot PRs
on: pull_request_target
on: pull_request

permissions:
pull-requests: write
Expand Down

0 comments on commit c795565

Please sign in to comment.