ci: move docker auth lower

grafana · Oct 16, 2024 · 651b394 · 651b394
1 parent 984b7af
commit 651b394
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/.github/workflows/helm-weekly-release-pr.yaml b/.github/workflows/helm-weekly-release-pr.yaml
@@ -13,12 +13,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: "Login to DockerHub (from vault)"
-        uses: "grafana/shared-workflows/actions/dockerhub-login@main"
-      - uses: imjasonh/[email protected]
-      - run: |
-          echo "${DOCKER_PASSWORD}" | crane auth login https://registry.hub.docker.com --username "${DOCKER_USERNAME}" --password-stdin
-
       - id: "get_github_app_token"
         name: "get github app token"
         uses: "actions/create-github-app-token@v1"
@@ -27,6 +21,12 @@ jobs:
           owner: "${{ github.repository_owner }}"
           private-key: "${{ secrets.APP_PRIVATE_KEY }}"
 
+      - name: "Login to DockerHub (from vault)"
+        uses: "grafana/shared-workflows/actions/dockerhub-login@main"
+      - uses: imjasonh/[email protected]
+      - run: |
+          echo "${DOCKER_PASSWORD}" | crane auth login https://registry.hub.docker.com --username "${DOCKER_USERNAME}" --password-stdin
+
       - name: Update/regenerate files
         id: update-k
         run: bash .github/workflows/scripts/helm-weekly-release.sh -k