Skip to content

Commit

Permalink
ci: release workflow needs to use the GH App token (#14193)
Browse files Browse the repository at this point in the history
  • Loading branch information
trevorwhitney authored Sep 20, 2024
1 parent a4aee4f commit 47b9075
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/release-workflows.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ local imagePrefix = 'grafana';
imagePrefix='grafana',
releaseLibRef=releaseLibRef,
releaseRepo='grafana/loki',
useGitHubAppToken=false,
useGitHubAppToken=true,
), false, false
),
'check.yml': std.manifestYamlDoc({
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ env:
PUBLISH_TO_GCS: false
RELEASE_LIB_REF: "main"
RELEASE_REPO: "grafana/loki"
USE_GITHUB_APP_TOKEN: false
USE_GITHUB_APP_TOKEN: true
jobs:
createRelease:
if: "${{ fromJSON(needs.shouldRelease.outputs.shouldRelease) }}"
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -915,5 +915,5 @@ ifeq ($(BUILD_IN_CONTAINER),true)
else
@$(MAKE) release-workflows
@echo "Checking diff"
@git diff --exit-code -- ".github/workflows/*release*" || (echo "Please build release workflows by running 'make release-workflows'" && false)
@git diff --exit-code --ignore-space-at-eol -- ".github/workflows/*release*" || (echo "Please build release workflows by running 'make release-workflows'" && false)
endif

0 comments on commit 47b9075

Please sign in to comment.