Skip to content

Commit

Permalink
Update docs on using terraform to create s3 buckets for accuracy
Browse files Browse the repository at this point in the history
The oidc_provider variable is invalid for the Terraform module, which extracts the provide info from the given EKS cluster.
The terraform requires a namespace for the service account, which was undocumented here.
The s3 bucket name will not work as loki-data as s3 bucket names are global, so we should encourage setting it explicitly.
The syntax for applying a terraform module was incorrect: missing `apply` command and variables were given with incorrect syntax.
  • Loading branch information
hypesystem committed Dec 16, 2024
1 parent 96ea4b1 commit 155a34b
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions docs/sources/configure/storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -342,19 +342,16 @@ This guide assumes a provisioned EKS cluster.
export AWS_REGION=<region of EKS cluster>
```

4. Save the OIDC provider in an environment variable:

```bash
oidc_provider=$(aws eks describe-cluster --name <EKS cluster> --query "cluster.identity.oidc.issuer" --output text | sed -e "s/^https:\/\///")
4. Apply the Terraform module:

```sh
terraform apply \
-var=region="$AWS_REGION" \
-var=cluster_name=<EKS cluster> \
-var=namespace=<service account namespace>
-var=bucket_name=<s3 bucket name>
```

See the [IAM OIDC provider guide](https://docs.aws.amazon.com/eks/latest/userguide/enable-iam-roles-for-service-accounts.html) for a guide for creating a provider.

5. Apply the Terraform module `terraform -var region="$AWS_REGION" -var cluster_name=<EKS cluster> -var oidc_id="$oidc_provider"`

Note, the bucket name defaults to `loki-data` but can be changed via the
`bucket_name` variable.

### Azure deployment (Azure Blob Storage Single Store)

#### Using account name and key
Expand Down

0 comments on commit 155a34b

Please sign in to comment.