Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerations is an array and has been updated as such in the values.schema.json #481

Closed
wants to merge 1 commit into from

Conversation

ollie-kane-CB
Copy link

Simple pull request to fix a typo. Without this, you must use --skip-schema-validation to install the chart that uses tolerations as they're not object values; they're an array of objects.

The sample values in this project wouldn't pass validation.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024

CLA assistant check
All committers have signed the CLA.

@yorugac
Copy link
Collaborator

yorugac commented Oct 31, 2024

Thanks for the PR, @ollie-kane-CB! I believe this is the same change request I've asked in #474 🙂

@@ -61,7 +61,7 @@ affinity: {}
# type: object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# type: object
# type: array

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ollie-kane-CB, there is a one-line fix that should be added; please see my comment above. Also, could you please rebase your PR against the new main branch?

@yorugac
Copy link
Collaborator

yorugac commented Oct 31, 2024

@ollie-kane-CB, it appears you've closed the PR: is it intentional?

@ollie-kane-CB
Copy link
Author

I was fumbling with github's idiosyncracies (i'm a gitlabber, so it's like a parallel universe) and was struggling to rebase. I closed because I don't know when I'll get around to fixing and didn't want to create noise. I'll re-open in a few days to resolve.

@yorugac
Copy link
Collaborator

yorugac commented Nov 1, 2024

@ollie-kane-CB, thanks for the clarification! FYI, I've fixed tolerations separately here: #484 in order to make a Helm release sooner. This schema bug has already remained un-fixed for way too long, IMO, so I'd like to rectify that ASAP.

Just in case, you're very welcome to pick up some other issue if you'd like to! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants