Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm template indentation for deployment.env #314

Closed
wants to merge 1 commit into from

Conversation

shippo-eric
Copy link

This is a simple yaml typo fix. Helm template indentation for env needs to be incremented.

before:

          env:
          foo: bar

after fix:

          env:
            foo: bar

I take the liberty to update chart version, but feel free to let me know if that's not desired.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shippo-eric
Copy link
Author

I made a mistake and realized env is a list of key/value pair, this is all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants