Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove top newline from config/crd yaml #295

Closed
wants to merge 1 commit into from

Conversation

KaranbirSingh7
Copy link

What?

  • kept running into the issue where copying CRD directly from k6-operator repo would always have an extra newline at top before YAML starts (not sure if this is intentional, left for future comments maybe?!) but this does cause a minor inconvenience when copying/pasting.

Why?

  • to allow copy/pasting without extra newline

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023

CLA assistant check
All committers have signed the CLA.

@yorugac
Copy link
Collaborator

yorugac commented Sep 29, 2023

Hi @KaranbirSingh7, thanks for the PR but I'm afraid I cannot merge it. These manifests are auto-generated so they shouldn't be edited manually.

Good news is that the newline might disappear in future updates of dependencies. Specifically, related issue that will be worked on very soon: #273

@yorugac yorugac closed this Sep 29, 2023
@KaranbirSingh7
Copy link
Author

I wasn't aware of that. Fair point & thanks for clarifying @yorugac 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants