fix: treat Failed as error during test init #291
Conversation
Signed-off-by: Jorge Turrado <[email protected]>
|
is there a way to distinguish Test Errors ( for instance the ones from thresholds ) from Errors due to not being able to launch K6? I think it would give more insights for troubleshooting. |
I think that we can add another state like |
| case "Failed": | ||
| // the init job has failed | ||
| returnErr = errors.New("init job has failed") | ||
| log.Error(returnErr, "error:") |
There was a problem hiding this comment.
I think the if check for "Failed" phase over here would be sufficient. And return of error as you did. So smth like:
| case "Failed": | |
| // the init job has failed | |
| returnErr = errors.New("init job has failed") | |
| log.Error(returnErr, "error:") | |
| if initializerPhase == "Failed" { | |
| // the initializer job has failed | |
| returnErr = errors.New("initializer job has failed") | |
| log.Error(returnErr, "error:") | |
| } |
Please use "initializer" so as to distinguish from "init container".
| k6.Status.Stage = "error" | ||
| if _, err := r.UpdateStatus(ctx, k6, log); err != nil { | ||
| return ctrl.Result{}, err | ||
| } |
There was a problem hiding this comment.
This should now go a bit later in logic, over here:
k6-operator/controllers/k6_initialize.go
Line 65 in 568d40e
Also, the change of Status is done via k6.GetStatus().Stage = ... for the moment.
|
Hello. |
|
Since there is no movement, we have created a new one here. |
|
Closing this due to PR #401 being merged. |
Fixes #290