Remove ANY option for interpolated property quality #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
kevinwcyu
approved these changes
Jul 17, 2024
Comment on lines
107
to
110
| let currQualities = qualities; | ||
| if (query.queryType === QueryType.PropertyInterpolated) { | ||
| currQualities = qualities.slice(1); | ||
| } |
There was a problem hiding this comment.
nit:
add this to the top of the file underneath where const qualities is defined so it's only created once.
const interpolatedPropertyQualities: Array<SelectableValue<SiteWiseQuality>> = qualities.slice(1);
and change this here to
Suggested change
| let currQualities = qualities; | |
| if (query.queryType === QueryType.PropertyInterpolated) { | |
| currQualities = qualities.slice(1); | |
| } | |
| const currQualities = query.queryType === QueryType.PropertyInterpolated ? interpolatedPropertyQualities : qualities; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a "Get interpolated property values" query is used with
Qualityset toANY(which is the default option) it errors because it's not a valid value for the query. This PR removes it from the options for interpolated queries and automatically replacesANYwithGOODon the backend (since it works on a first run and by usingGOODthat's probably in line with users expect)Which issue(s) this PR fixes:
Fixes #326
Special notes for your reviewer: