Update to use GetSessionWithAuthSettings #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
sarahzinger and
kevinwcyu
and removed request for
a team
sarahzinger
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates grafana-aws-sdk to use grafana/grafana-aws-sdk#144. I have mixed feelings about the way we're currently using the session and the client, but since it ends up being one SessionCache per instance I decided to leave it alone for simplicity
I checked for
os,osutil, andfspackages, and the only uses of it are in tests.There are no global variables for state.
fixes https://github.com/grafana/oss-plugin-partnerships/issues/946