Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Editor: Improve menu placement for dropdowns #292

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Mar 18, 2024

What this PR does / why we need it:

Sometimes when dropdowns have a lot of items, some of them are not visible because the Select prop always places the dopdown on the bottom. This changes the placement to "auto".

Before:
Screenshot 2024-03-18 at 17 27 51

After:
Screenshot 2024-03-18 at 17 18 32

@idastambuk idastambuk requested a review from a team as a code owner March 18, 2024 16:24
@idastambuk idastambuk requested review from iwysiu and njvrzm and removed request for a team March 18, 2024 16:24
@idastambuk idastambuk changed the title Query Editor: Improve menu placement automatic Query Editor: Improve menu placement for dropdowns Mar 18, 2024
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@idastambuk idastambuk merged commit bb305e2 into main Mar 19, 2024
12 checks passed
@idastambuk idastambuk deleted the menu-placement branch March 19, 2024 10:36
@idastambuk idastambuk mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants