Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 18 #218

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Support Node 18 #218

merged 1 commit into from
Oct 23, 2023

Conversation

kevinwcyu
Copy link
Contributor

  • Made the minimal amount of updates to dependencies to support Node 18
  • Tested with Node v18.17.1 locally with the following rm -rf node_modules && yarn && yarn lint && yarn test:ci && yarn build then tested it with a simple query
  • Changes to src/DataSource.test.ts are from updating @grafana/eslint-config and running yarn lint:fix

@kevinwcyu kevinwcyu requested a review from a team as a code owner September 14, 2023 19:40
@kevinwcyu kevinwcyu requested review from iwysiu and sarahzinger and removed request for a team September 14, 2023 19:40
@kevinwcyu kevinwcyu merged commit 8f0c951 into main Oct 23, 2023
2 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/node-18 branch October 23, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinwcyu @sarahzinger