Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Update to version 11.4.0 #3475

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

terop
Copy link
Contributor

@terop terop commented Dec 10, 2024

No description provided.

@terop
Copy link
Contributor Author

terop commented Dec 10, 2024

I am not sure whether the minor version of the chart version should be updated instead of patch when the application minor version is updated. Please let me know if it should be changed.

@jkroepke
Copy link
Collaborator

I am not sure whether the minor version of the chart version should be updated instead of patch when the application minor version is updated. Please let me know if it should be changed.

According to semver Patch for fixes and minor for new features.

Bump minor would be a better option.

I'm pre-approve that so the second reviewer could take note of that.

@terop terop force-pushed the grafana/update_11_4_0 branch from 35342ab to 077e417 Compare December 11, 2024 17:04
@terop
Copy link
Contributor Author

terop commented Dec 11, 2024

Thank you for the comment @jkroepke. I updated the version field per your suggestion.

@Sheikh-Abubaker Sheikh-Abubaker merged commit ca54f24 into grafana:main Dec 12, 2024
6 checks passed
@terop terop deleted the grafana/update_11_4_0 branch December 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants