Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki-distributed] Add resource requests and limits to tokengen job template #3467

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wessp01
Copy link

@wessp01 wessp01 commented Dec 5, 2024

The job-tokengen.yaml template within the Helm chart currently does not include resource limits and requests for both initContainers and regular containers.

By adding resource configuration to the chart, we ensure that users can specify limits and requests for CPU and memory, preventing such errors and allowing users to manage resource quotas more effectively.

What has been changed:

  • Added resource limits and requests configuration to initContainers and containers.
  • The resource values are read from the chart’s values.yaml.

Why is this useful:

  • Resolves errors related to missing resource limits in Kubernetes resource quotas.
  • Provides flexibility to users to define the resource needs of their jobs.
  • Aligns with best practices for managing resources in Kubernetes.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2024

CLA assistant check
All committers have signed the CLA.

@Sheikh-Abubaker Sheikh-Abubaker added the enhancement New feature or request label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants