[tempo-distributed] Ommited unsupported log levels #3462
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
xogoodnow
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
Signed-off-by: xogoodnow <[email protected]>
|
Hi @zalegrala, Thank you. cheers |
joe-elliott
approved these changes
Dec 13, 2024
|
Hi @xogoodnow, yes two reviews for all helm-charts PRs. The conflicts will need to be addressed since there was another chart change before this one. |
Signed-off-by: Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trace log level is not supported by the library
the which is being used here does not support the mentioned log levels
https://github.com/grafana/dskit/blob/main/server/server.go#L20
here are the supported log levels:
https://github.com/go-kit/log/blob/main/level/level.go#L78
errors:
failed parsing config: failed to parse configFile /conf/tempo.yaml: unrecognized log level "trace"
failed parsing config: failed to parse configFile /conf/tempo.yaml: unrecognized log level "fatal"
failed parsing config: failed to parse configFile /conf/tempo.yaml: unrecognized log level "panic"