[tempo-distributed] Fix global.extraEnv key support for metrics-generator statefulset #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruksnys
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
bruksnys
force-pushed
the
main
branch
2 times, most recently
from
81eec52 to
60fc66c
Compare
|
Hey @bruksnys Thanks for the contribution! could you please address the failed CI check by running |
Signed-off-by: Linas Klimaitis <[email protected]>
Sure thing! I've already re-run the helm-docs and will be waiting for the green pipeline! 👍 |
|
@Sheikh-Abubaker All of the checks are now passing, please let me know if anything else is needed on my side. Thank you! |
|
|
|
updated, signed CLA. |
Signed-off-by: MH <[email protected]> Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]> Signed-off-by: MH <[email protected]>
zanhsieh
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes global.extraEnv key support for metrics-generator when it is deployed as kind: StatefulSet
Resolves: #3346