[tempo-distributed] Adds global extraEnv support to deployed components #3333
Conversation
rbrady
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
rbrady
changed the title
rbrady
force-pushed
the
rbrady/3332-apply-global-extraEnv
branch
from
e0e60d6 to
32b098a
Compare
There was a problem hiding this comment.
Hey @rbrady could you please share the mimir reference for this change.
rbrady
force-pushed
the
rbrady/3332-apply-global-extraEnv
branch
from
32b098a to
8257470
Compare
There was a problem hiding this comment.
LGTM! Thanks! for the Contribution @rbrady, keep them coming!
Most of the deployed components did not apply the global extraEnv in the deployment templates. This resulted in having to duplicate extraEnv vars in the values/overrides files. This change uses the pattern from mimir to create an env: for a deployment if the .Values.global.extraEnv or .Values.<component>.extraEnv exists. It also adds the global extraEnv section to the values.yaml file. Signed-off-by: Ryan Brady <[email protected]>
rbrady
force-pushed
the
rbrady/3332-apply-global-extraEnv
branch
from
8257470 to
2126cb6
Compare
| @@ -70,9 +70,14 @@ spec: | |||
| name: http-metrics | |||
| - containerPort: {{ include "tempo.memberlistBindPort" . }} | |||
| name: http-memberlist | |||
| {{- with .Values.compactor.extraEnv }} | |||
There was a problem hiding this comment.
Is there any reason you changed .Values.compactor.extraEnv to .Values.compactor.env in the compactor but for distributor you left it the same?
This is just an example, other components are a bit inconsistent as well.
I think we should keep .Values.compactor.extraEnv as is not a breaking change.
I realize is just a copy paaste issue because you used {{- with .Values.compactor.extraEnv }} inside the if.
There was a problem hiding this comment.
@andreigorgan Thanks for pointing this out, I'll patch it by opening a PR
Most of the deployed components did not apply the global extraEnv in the deployment templates. This resulted in having to duplicate extraEnv vars in the values/overrides files. This change uses the pattern from mimir to create an env: for a deployment if the .Values.global.extraEnv or .Values..extraEnv exists. It also adds the global extraEnv section to the values.yaml file.
Closes #3332