Skip to content

Commit

Permalink
Merge pull request #3361 from kovaxur/ingress-service-type
Browse files Browse the repository at this point in the history
[tempo-distributed] Service type and internalTrafficPolicy settings to Ingress/Distributor
  • Loading branch information
Sheikh-Abubaker authored Nov 14, 2024
2 parents b011e27 + 3710e96 commit d9107be
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/tempo-distributed/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.21.1
version: 1.22.0
appVersion: 2.6.0
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
5 changes: 4 additions & 1 deletion charts/tempo-distributed/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# tempo-distributed

![Version: 1.21.1](https://img.shields.io/badge/Version-1.21.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.6.0](https://img.shields.io/badge/AppVersion-2.6.0-informational?style=flat-square)
![Version: 1.22.0](https://img.shields.io/badge/Version-1.22.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.6.0](https://img.shields.io/badge/AppVersion-2.6.0-informational?style=flat-square)

Grafana Tempo in MicroService mode

Expand Down Expand Up @@ -348,6 +348,7 @@ The memcached default args are removed and should be provided manually. The sett
| distributor.resources | object | `{}` | Resource requests and limits for the distributor |
| distributor.service.annotations | object | `{}` | Annotations for distributor service |
| distributor.service.externalTrafficPolicy | string | `nil` | If type is LoadBalancer you can set it to 'Local' [preserve the client source IP](https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip) |
| distributor.service.internalTrafficPolicy | string | `"Cluster"` | https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/ |
| distributor.service.labels | object | `{}` | Labels for distributor service |
| distributor.service.loadBalancerIP | string | `""` | If type is LoadBalancer you can assign the IP to the LoadBalancer |
| distributor.service.loadBalancerSourceRanges | list | `[]` | If type is LoadBalancer limit incoming traffic from IPs. |
Expand Down Expand Up @@ -548,6 +549,8 @@ The memcached default args are removed and should be provided manually. The sett
| ingester.replicas | int | `3` | Number of replicas for the ingester |
| ingester.resources | object | `{}` | Resource requests and limits for the ingester |
| ingester.service.annotations | object | `{}` | Annotations for ingester service |
| ingester.service.internalTrafficPolicy | string | `"Cluster"` | https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/ |
| ingester.service.type | string | `"ClusterIP"` | Type of the service: https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types |
| ingester.terminationGracePeriodSeconds | int | `300` | Grace period to allow the ingester to shutdown before it is killed. Especially for the ingestor, this must be increased. It must be long enough so ingesters can be gracefully shutdown flushing/transferring all data and to successfully leave the member ring on shutdown. |
| ingester.tolerations | list | `[]` | Tolerations for ingester pods |
| ingester.topologySpreadConstraints | string | Defaults to allow skew no more then 1 node per AZ | topologySpread for ingester pods. Passed through `tpl` and, thus, to be configured as string |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ metadata:
{{- tpl (toYaml . | nindent 4) $ }}
{{- end }}
spec:
internalTrafficPolicy: {{ .Values.distributor.service.internalTrafficPolicy }}
type: {{ .Values.distributor.service.type }}
ports:
- name: http-metrics
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ metadata:
{{- tpl (toYaml . | nindent 4) $ }}
{{- end }}
spec:
type: {{ .Values.ingester.service.type }}
internalTrafficPolicy: {{ .Values.ingester.service.internalTrafficPolicy }}
ports:
- name: http-metrics
port: 3100
Expand Down
6 changes: 6 additions & 0 deletions charts/tempo-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ ingester:
service:
# -- Annotations for ingester service
annotations: {}
# -- Type of the service: https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types
type: ClusterIP
# -- https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/
internalTrafficPolicy: Cluster
# -- Adds the appProtocol field to the ingester service. This allows ingester to work with istio protocol selection.
appProtocol:
# -- Set the optional grpc service protocol. Ex: "grpc", "http2" or "https"
Expand Down Expand Up @@ -478,6 +482,8 @@ distributor:
loadBalancerSourceRanges: []
# -- If type is LoadBalancer you can set it to 'Local' [preserve the client source IP](https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip)
externalTrafficPolicy: null
# -- https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/
internalTrafficPolicy: Cluster
serviceDiscovery:
# -- Annotations for distributorDiscovery service
annotations: {}
Expand Down

0 comments on commit d9107be

Please sign in to comment.