feat: Pull Request Reviews #402
Open
+811
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHackman
commented
Dec 11, 2024
Comment on lines
+108
to
+125
| data.NewField("pull_request_number", nil, []int64{}), | ||
| data.NewField("pull_request_title", nil, []string{}), | ||
| data.NewField("pull_request_state", nil, []string{}), | ||
| data.NewField("pull_request_url", nil, []string{}), | ||
| data.NewField("pull_request_author_name", nil, []string{}), | ||
| data.NewField("pull_request_author_login", nil, []string{}), | ||
| data.NewField("pull_request_author_email", nil, []string{}), | ||
| data.NewField("pull_request_author_company", nil, []string{}), | ||
| data.NewField("repository", nil, []string{}), | ||
| data.NewField("review_author_name", nil, []string{}), | ||
| data.NewField("review_author_login", nil, []string{}), | ||
| data.NewField("review_author_email", nil, []string{}), | ||
| data.NewField("review_author_company", nil, []string{}), | ||
| data.NewField("review_url", nil, []string{}), | ||
| data.NewField("review_state", nil, []string{}), | ||
| data.NewField("review_comment_count", nil, []int64{}), | ||
| data.NewField("review_updated_at", nil, []time.Time{}), | ||
| data.NewField("review_created_at", nil, []time.Time{}), |
There was a problem hiding this comment.
Not sure if I love the prefixes here, but to be the most straightforward to users this felt right?
NickHackman
commented
Dec 11, 2024
Comment on lines
+208
to
+211
| variables["reviewCursor"] = pr.Reviews.PageInfo.EndCursor | ||
| if err := client.Query(ctx, q, variables); err != nil { | ||
| return nil, errors.WithStack(err) | ||
| } |
There was a problem hiding this comment.
Majority of cases this'll never happen, but covering the case of more than 100 reviews
NickHackman
commented
Dec 11, 2024
| URL string | ||
| Author Author | ||
| State githubv4.PullRequestReviewState | ||
| CommentsCount int64 |
There was a problem hiding this comment.
Just keeping track of the number of comments; otherwise, this gets even more nested with PRs containing Reviews containing Comments
NickHackman
commented
Dec 11, 2024
|
|
||
| const defaultTimeField = timeFieldOptions[0].value; | ||
|
|
||
| const QueryEditorPullRequestReviews = (props: Props) => { |
There was a problem hiding this comment.
This is a copy and paste of the Pull Request one as they're going to be identical form wise
Unused variable results in errors
Panda's Pull Reminders Example Leaderboard Panel
Panel JSON{
"type": "table",
"title": "Leaderboard",
"gridPos": {
"x": 0,
"y": 0,
"w": 12,
"h": 8
},
"datasource": {
"uid": "ae6qd8evnl1xcd",
"type": "grafana-github-datasource"
},
"id": 1,
"targets": [
{
"datasource": {
"type": "grafana-github-datasource",
"uid": "ae6qd8evnl1xcd"
},
"refId": "A",
"queryType": "Pull_Request_Reviews",
"repository": "github-datasource",
"owner": "grafana",
"options": {
"query": "is:merged",
"timeField": 2
}
}
],
"options": {
"showHeader": true,
"cellHeight": "sm",
"footer": {
"show": false,
"reducer": [
"sum"
],
"countRows": false,
"fields": ""
}
},
"transformations": [
{
"id": "groupBy",
"options": {
"fields": {
"pull_request_number": {
"aggregations": [
"distinctCount"
],
"operation": "aggregate"
},
"review_author_login": {
"aggregations": [],
"operation": "groupby"
},
"review_comment_count": {
"aggregations": [
"sum"
],
"operation": "aggregate"
}
}
}
},
{
"id": "calculateField",
"options": {
"mode": "binary",
"reduce": {
"reducer": "sum"
},
"binary": {
"left": "review_comment_count (sum)",
"operator": "/",
"right": "pull_request_number (distinctCount)"
},
"alias": ""
}
},
{
"id": "organize",
"options": {
"excludeByName": {},
"indexByName": {},
"renameByName": {
"review_author_login": "Author",
"review_comment_count (sum)": "Comments",
"pull_request_number (distinctCount)": "Pull Requests Reviewed",
"Ratio": "",
"review_comment_count (sum) / pull_request_number (distinctCount)": "Ratio"
},
"includeByName": {}
}
}
],
"fieldConfig": {
"defaults": {
"custom": {
"align": "auto",
"cellOptions": {
"type": "auto"
},
"inspect": false
},
"mappings": [],
"thresholds": {
"mode": "absolute",
"steps": [
{
"value": null,
"color": "green"
},
{
"value": 80,
"color": "red"
}
]
},
"color": {
"mode": "thresholds"
}
},
"overrides": [
{
"matcher": {
"id": "byName",
"options": "Author"
},
"properties": [
{
"id": "links",
"value": [
{
"title": "",
"url": "https://github.com/${__data.fields.Author}",
"targetBlank": true
}
]
}
]
}
]
},
"pluginVersion": "10.4.2",
"description": "Example panel akin to Panda's Pull Reminders Analytics"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70 EDIT: realizing that #70 is already covered by current features
This introduces a new query type of Pull Request Reviews. This is separate from Pull Requests due to
adding more paginated queries to handle more than 100 reviews (I imagine this is quite rare) as well as pulling more data.
Combining pull requests and reviews results in a lot of duplication that doesn't make sense for other PR use cases. I believe I've implemented all the necessary components here for this integration, but please let me know if I'm missing anything
Use Case