Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config update #387

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Config update #387

merged 11 commits into from
Nov 26, 2024

Conversation

yesoreyeram
Copy link
Contributor

@yesoreyeram yesoreyeram commented Nov 18, 2024 •
edited
Loading

This PR updates the following

  • Added analytics/rudderstack for the health check failures
  • Improve health check error messages
  • Handle/Differentiate Github Enterprise Cloud vs Github Enterprise Server. Fixes https://github.com/grafana/support-escalations/issues/11808
  • Docs update about fine grained access tokens
  • Updated/Fixed links in the config page
  • Typescript improvements for config section to align with other plugins

Before changes

image image

After changes

image image

@yesoreyeram yesoreyeram requested a review from a team as a code owner November 18, 2024 12:29
ivanahuckova
ivanahuckova reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comment bellow 🙂

Additionally, I would also rename useGitHubEnterprise -> useGitHubEnterpriseServer in pkg/github/client/client.go just to make it more clear.

docs/sources/setup/datasource.md Outdated Show resolved Hide resolved
docs/sources/setup/token.md Outdated Show resolved Hide resolved
docs/sources/setup/token.md Outdated Show resolved Hide resolved
docs/sources/setup/token.md Outdated Show resolved Hide resolved
docs/sources/setup/token.md Outdated Show resolved Hide resolved
src/types/config.ts Show resolved Hide resolved
src/views/ConfigEditor.tsx Outdated Show resolved Hide resolved
src/views/ConfigEditor.tsx Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/views/ConfigEditor.tsx Outdated Show resolved Hide resolved
@ivanahuckova ivanahuckova mentioned this pull request Nov 22, 2024
Open
ivanahuckova
ivanahuckova approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Non-blocking nit, I'd suggest renaming src/types.ts to query.ts and moving it under types folder, to be consistent.

@yesoreyeram yesoreyeram merged commit c6f8637 into main Nov 26, 2024
10 checks passed
@yesoreyeram yesoreyeram deleted the config-update branch November 26, 2024 16:37
@yesoreyeram yesoreyeram mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesoreyeram @ivanahuckova